Move generic flags to core.h #2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjeffery
force-pushed
the
generic_flags
branch
from
db8afd8 to
13e427d
Compare
jeromekelleher
approved these changes
Apr 28, 2022
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
LGTM, one tweak suggested
c/tskit/core.h
Outdated
|
|
||
| /** @brief Instead of taking a copy of input data, take ownership of it | ||
| * and its lifecycle */ | ||
| #define TSK_TAKE_OWNERSHIP (1 << 28) |
Member
There was a problem hiding this comment.
Might as well make this (1u << 28). Probably makes no difference, but saves future readers wondering why its different to others.
benjeffery
force-pushed
the
generic_flags
branch
from
13e427d to
6bf0ce2
Compare
Codecov Report
@@ Coverage Diff @@
## main #2230 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 27 27
Lines 25994 25994
Branches 1165 1165
=======================================
Hits 24251 24251
Misses 1713 1713
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2218
Instead of moving to trees.h it seemed to make more sense to move all the generic flags to
core.hthen all flags in other files should be namespaced to a function.