Skip to content

Conversation

@benjeffery
Copy link
Member

Add migration metadata, note that like edges this is backward compatible as the columns are optional in the kastore.

@benjeffery benjeffery force-pushed the migration-metadata branch 2 times, most recently from 81e6465 to 8d724c1 Compare March 30, 2020 19:17
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #505 into master will decrease coverage by 0.12%.
The diff coverage is 74.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   87.08%   86.96%   -0.13%     
==========================================
  Files          21       21              
  Lines       15597    15748     +151     
  Branches     3036     3066      +30     
==========================================
+ Hits        13583    13695     +112     
- Misses       1006     1034      +28     
- Partials     1008     1019      +11     
Flag Coverage Δ
#c_tests 87.94% <67.69%> (-0.23%) ⬇️
#python_c_tests 90.52% <95.16%> (+0.06%) ⬆️
#python_tests 99.18% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
c/tskit/tables.c 77.74% <63.79%> (-0.42%) ⬇️
python/_tskitmodule.c 84.21% <93.75%> (+0.16%) ⬆️
python/tskit/tables.py 99.80% <100.00%> (+<0.01%) ⬆️
python/tskit/trees.py 98.60% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73d85a...6e5eedf. Read the comment docs.

@benjeffery
Copy link
Member Author

Looks like I broke the docs, will fix later as AFK.

@benjeffery
Copy link
Member Author

@jeromekelleher ready for a once over.

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @benjeffery. Spotted a few minor typos and a query about whether we want to bump the minor version number.

@benjeffery
Copy link
Member Author

@jeromekelleher Ok, all fixed.

@jeromekelleher jeromekelleher merged commit f53ff61 into tskit-dev:master Mar 31, 2020
@jeromekelleher
Copy link
Member

Merged, thanks. OK, that's the boring stuff out of the way!

@benjeffery benjeffery deleted the migration-metadata branch March 31, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants