Allow mixture of known and unknown as long as they are on different sites #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 24 24
Lines 19387 19388 +1
Branches 3640 3640
=======================================
+ Hits 17001 17002 +1
Misses 1297 1297
Partials 1089 1089
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jeromekelleher
requested changes
Aug 10, 2020
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
LGTM, just needs a minor tweak in the loop logic.
benjeffery
force-pushed
the
mixed_time_check_per_site
branch
from
0005652 to
1cf3d3a
Compare
jeromekelleher
approved these changes
Aug 11, 2020
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
LGTM, thanks @benjeffery !
AdminBot-tskit
force-pushed
the
mixed_time_check_per_site
branch
from
1cf3d3a to
1e9f7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #748 by relaxing the constraint on mutation times to allow mixtures of known/unknown as long as they are on different sites.