Set .span property for Interval #811
Conversation
hyanwong
force-pushed
the
span-for-interval
branch
from
de2ffd9 to
686f7c6
Compare
|
Tests are very minimal, but I can't think of any corner cases, really. |
|
It'd be nice to do a bit more testing. To pass these tests, all I'd need to do is have @property
def span(self):
return 1.0 |
hyanwong
force-pushed
the
span-for-interval
branch
from
686f7c6 to
f60f589
Compare
|
Like this? I simply changed it to test a few trees. |
python/tests/test_highlevel.py
Outdated
| self.assertGreater(ts.num_trees, 1) | ||
| breakpoints = list(ts.breakpoints()) | ||
| self.assertEqual(breakpoints[0], 0) | ||
| self.assertAlmostEqual(breakpoints[-1], ts.sequence_length) |
There was a problem hiding this comment.
Should be exactly equal, shouldn't they? We'd only expect numerical differences if we've performed some calculations on the values.
There was a problem hiding this comment.
Fine. I wasn't sure how the breakpoints were calculated, but if the last one is simply passed through from the seq length, then that should be fine. I'll change it.
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
Looks good, thanks @hyanwong. Minor comment.
benjeffery
left a comment
benjeffery
left a comment
There was a problem hiding this comment.
Sorry @hyanwong I missed the notifications on your push. Looks good modulo JK's comment.
hyanwong
force-pushed
the
span-for-interval
branch
from
f60f589 to
6367e37
Compare
|
Should be done now |
3 participants
No description provided.