check equality for missing times in mutation table rows

[petrelharp]

Closes #821, although not in the most elegant way.

[petrelharp]

Also a small clarifying note about pre-commit.

... which is not working for me, for some reason: running pre-commit run does everything as expected, but then git commit fails with a bunch of flake8 errors beginning with

python/tskit/metadata.py:161:13: F541 f-string is missing placeholders
python/tskit/util.py:111:26: E203 whitespace before ':'
python/tskit/util.py:129:31: E203 whitespace before ':'
python/tskit/util.py:189:23: E203 whitespace before ':'
python/tskit/util.py:207:36: E203 whitespace before ':'

The only way to get it to commit is to use --no-verify. I've uninstalled/reinstalled the pre-commit hooks, my flake8 is up to date, I've looked for other hooks... no idea what's going on. Any ideas?

[jeromekelleher]

LGTM, thanks @petrelharp. I think we should wait on @benjeffery before merging though (he'll be back in a few days).

[jeromekelleher]

Looks like you need an isinstance(other, MutationTableRow) here and return False otherwise.

[benjeffery]

Opps I meant to comment not approve - just that one fix to the eq method.

Thanks for finding and fixing my omission @petrelharp!

[petrelharp]

Thanks for finding and fixing my omission @petrelharp!

It's /our/ omission, isn't it? But, thanks for getting everything so wonderfully in line that the dangling ends are so minor!

[petrelharp]

I've added more tests. I think this is good to go.

[jeromekelleher]

LGTM. I'll let @benjeffery push the green button though, in case he sees anything.

[codecov]

Codecov Report

Merging #822 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #822   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files          24       24           
  Lines       19545    19547    +2     
  Branches      789      789           
=======================================
+ Hits        18290    18292    +2     
  Misses       1223     1223           
  Partials       32       32           

Impacted Files	Coverage Δ
python/tskit/tables.py	99.70% <100.00%> (+<0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0f04f...4be313c. Read the comment docs.