Skip to content

Conversation

@hyanwong
Copy link
Member

Fixes #2411

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #2415 (d286619) into main (12afedc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2415      +/-   ##
==========================================
- Coverage   93.34%   93.33%   -0.01%     
==========================================
  Files          28       28              
  Lines       26988    26978      -10     
  Branches     1246     1245       -1     
==========================================
- Hits        25191    25181      -10     
  Misses       1763     1763              
  Partials       34       34              
Flag Coverage Δ
c-tests 92.26% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 71.00% <100.00%> (-0.03%) ⬇️
python-tests 98.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/tables.py 98.96% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12afedc...d286619. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 86c2eb4 into tskit-dev:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify replace_with implementation

2 participants