Change diff iter types to tsk_ equivalents #788
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyanwong
force-pushed
the
diff-iter-types
branch
3 times, most recently
from
27c56e6 to
9883fa3
Compare
hyanwong
force-pushed
the
diff-iter-types
branch
from
9883fa3 to
f9a4a97
Compare
jeromekelleher
approved these changes
Aug 24, 2020
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
LGTM, thanks.
But let's keep this one queued up for post release.
Member
Author
|
Included with #787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on slack. I don't think any of these are exposed to Python, so conversion to/from python equivalents shouldn't catch us out here.