New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage message + bugfix when using tslide in a pipe #10

Merged
merged 2 commits into from May 26, 2016

Conversation

Projects
None yet
2 participants
@noffle
Member

noffle commented May 26, 2016

No description provided.

noffle added some commits May 1, 2016

Don't move cursor if terminal has unknown height.
This happens when you're using tslide through e.g. a pipe and
process.stdout doesn't know the height of the terminal. Without this
commit the behaviour was to evaluate process.stdout.rows to NaN and
write garbage -- this elides writing cursor ansi codes altogether.

@noffle noffle merged commit 1f9b577 into tslide:master May 26, 2016

@rafaelrinaldi

This comment has been minimized.

Show comment
Hide comment
@rafaelrinaldi

rafaelrinaldi May 26, 2016

Collaborator

@noffle no code review? 😢

Collaborator

rafaelrinaldi commented May 26, 2016

@noffle no code review? 😢

@noffle

This comment has been minimized.

Show comment
Hide comment
@noffle

noffle May 26, 2016

Member

You're right! I'm a villain. Please feel free to CR retroactively -- happy
to make revisions or push an emergency fix if I've goofed anything.
On May 26, 2016 2:29 PM, "Rafael Rinaldi" notifications@github.com wrote:

@noffle https://github.com/noffle no code review? 😢


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

Member

noffle commented May 26, 2016

You're right! I'm a villain. Please feel free to CR retroactively -- happy
to make revisions or push an emergency fix if I've goofed anything.
On May 26, 2016 2:29 PM, "Rafael Rinaldi" notifications@github.com wrote:

@noffle https://github.com/noffle no code review? 😢


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

@rafaelrinaldi

This comment has been minimized.

Show comment
Hide comment
@rafaelrinaldi

rafaelrinaldi May 26, 2016

Collaborator

@noffle NP man, just feel free to use my help whenever you want 👍

Collaborator

rafaelrinaldi commented May 26, 2016

@noffle NP man, just feel free to use my help whenever you want 👍

@noffle

This comment has been minimized.

Show comment
Hide comment
@noffle

noffle May 26, 2016

Member

I will! Really happy this thing has such interest behind it.
On May 26, 2016 2:34 PM, "Rafael Rinaldi" notifications@github.com wrote:

@noffle https://github.com/noffle NP man, just feel free to use my help
whenever you want 👍


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

Member

noffle commented May 26, 2016

I will! Really happy this thing has such interest behind it.
On May 26, 2016 2:34 PM, "Rafael Rinaldi" notifications@github.com wrote:

@noffle https://github.com/noffle NP man, just feel free to use my help
whenever you want 👍


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment