Allowing asynchronous ES queries #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| %% that's when the options passed to hackney included `async' | ||
| %% this reference can then be used to match the messages from | ||
| %% hackney when ES replies; see the hackney doc for more information | ||
| {ok, ClientRef}; | ||
| {error, R} -> | ||
| {error, R} |
There was a problem hiding this comment.
Note that I was tempted to replace the last 2 clauses, that essentially do nothing, by just a catch-all clause
Else -> Else, but that seemed to be somewhat opposed to the spirit of your code. Happy to change if you think it'd be better :) thanks!
Using hackney's option `async`
Wrapping hackney's reference in an `{async, Ref}' tuple to make it
easy to match.
Had to update the specs to account for that change
wk8
force-pushed
the
wk8/allow_async_queries
branch
from
0ffac31
to
f1ed6a3
Compare
tsloughter
added a commit
that referenced
this pull request
Feb 21, 2016
Allowing asynchronous ES queries
|
Thanks for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using hackney's option
async