Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix win32 password entry. #107

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jkrukoff
Copy link
Contributor

commented Mar 22, 2019

As Prompt is a binary, this patch prevents a run time error on
password blanking. This appears to be the only change needed to get the plugin working on windows again, after the original botched merge and subsequent emergency fix.

jkrukoff added some commits Mar 22, 2019

Fix win32 password entry.
As `Prompt` is a binary, this patch prevents a run time error on
password blanking.
Use byte_size instead of size.
Per review, use the more specific sizing function.
@starbelly

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

@jkrukoff yeah, i changed it to size because for some reason I got back strings and not binary, but it's been a minute, so I may not be remembering something correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.