Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline validation doesn't send group tax percentage #944

Closed
Luke1982 opened this issue Nov 2, 2020 · 2 comments
Closed

Inline validation doesn't send group tax percentage #944

Luke1982 opened this issue Nov 2, 2020 · 2 comments

Comments

@Luke1982
Copy link
Contributor

Luke1982 commented Nov 2, 2020

When I create a custom validation on one of the inventorymodules and then test it by editing the record in full the backend receives the entity (e.g. a SalesOrder) array that also includes the tax percentage per active tax (for example $entity['tax1_group_percentage']). But when I do an in-field edit, those array keys are not sent. I'd like to make sure the inline edit and full edit provide the validation backend with the same data.

@joebordes
Copy link
Contributor

this is not how inline edit works. inline edit only sends the field being modified in all modules.
I don't think we should treat the inventory modules differently than all the others in this aspect, I prefer being consistent.

convince me

@joebordes
Copy link
Contributor

closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants