New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor folder from repository #30

Open
EricTendian opened this Issue Apr 3, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@EricTendian

EricTendian commented Apr 3, 2017

Hi, I'm a new user of Tsugi and I noticed that this project has the vendor directory included in the repository. I recommend it should be removed and added to the .gitignore file, per the best practices described in "Should I commit the dependencies in my vendor directory?" I can make a new PR with the changes and update the docs if maintainers want this.

Is there some reasoning I'm missing for including it in the repository?

@csev

This comment has been minimized.

Show comment
Hide comment
@csev

csev Apr 22, 2017

Collaborator

The reasoning has been all along to keep things simple with a single git checkout. But recently as I have started to evolve to using Silex, the vendor folder is getting messy (it used to be only the tsusi-php library) it is probably to switch to the best practice.

My plan is to do more refactoring into silex while maintaining the pre-silex code like lessons.php and badges.php - and then make a tag and minor release and then after that minor release delete the pre-silex code and get rid of the vendor folder.

Sooo. It is coming after the next minor release.

Collaborator

csev commented Apr 22, 2017

The reasoning has been all along to keep things simple with a single git checkout. But recently as I have started to evolve to using Silex, the vendor folder is getting messy (it used to be only the tsusi-php library) it is probably to switch to the best practice.

My plan is to do more refactoring into silex while maintaining the pre-silex code like lessons.php and badges.php - and then make a tag and minor release and then after that minor release delete the pre-silex code and get rid of the vendor folder.

Sooo. It is coming after the next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment