Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using recommended lowercase reference to logrus #73

Merged
merged 2 commits into from Nov 6, 2017

Conversation

netguy204
Copy link
Contributor

Logrus authors recommend that references to the logrus package use only the lowercase variation. See https://github.com/sirupsen/logrus/blob/master/README.md

End user code will not build unless that code and all of its dependencies follow only a single logrus case convention.

Logrus authors recommend that references to the logrus
package use only the lowercase variation.
@netguy204
Copy link
Contributor Author

Can someone with more experience with the CI system take a look a these build logs? I'm not sure if I caused or should be concerned about the various error-like lines in the build output.

@timoha
Copy link
Collaborator

timoha commented Nov 6, 2017

the reason it's failing is because you imports are out of order for the following files:
caches.go
client.go
rpc.go
scanner.go

Just run them again gofmt to correct them

@codecov-io
Copy link

Codecov Report

Merging #73 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   54.66%   54.75%   +0.09%     
==========================================
  Files          21       21              
  Lines        2049     2049              
==========================================
+ Hits         1120     1122       +2     
+ Misses        866      865       -1     
+ Partials       63       62       -1
Impacted Files Coverage Δ
admin_client.go 0% <ø> (ø) ⬆️
rpc.go 68.71% <ø> (ø) ⬆️
client.go 30.84% <ø> (ø) ⬆️
scanner.go 86.18% <ø> (ø) ⬆️
region/client.go 80.89% <ø> (+0.81%) ⬆️
caches.go 80.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1c426...5094941. Read the comment docs.

@timoha
Copy link
Collaborator

timoha commented Nov 6, 2017

Thanks for contributing, in case you haven't done this yet, please sign the contributors agreement: https://github.com/tsuna/gohbase#contributing

@timoha timoha merged commit 9050082 into tsuna:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants