Add pool labelset to client #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: query escape on components_test.go:37 now that labels flag is added to the pool feat: changed request body from urlencoded to json refactor: tests now parse json body request fix: fixing broken tests caused by json body request feat: added test covering pool update --add-labels and pool update --remove-labels lint: fixing linting problem in test case fix: go.mod and go.sum fix: go.mod/go.sum fix: api spec from go-tsuruclient fix: innefectual assignment to err
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 66.75% 66.80% +0.04%
==========================================
Files 49 49
Lines 9055 9097 +42
==========================================
+ Hits 6045 6077 +32
- Misses 2086 2091 +5
- Partials 924 929 +5
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.