db: removed Storage.Close method

This method should not be used anymore. We should collect dead
connections and close it.

api/auth_test.go

@@ -44,7 +44,6 @@ func (s *AuthSuite) SetUpSuite(c *C) {
 }
 
 func (s *AuthSuite) TearDownSuite(c *C) {
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 }
 

api/handler_test.go

@@ -36,7 +36,6 @@ func (s *HandlerSuite) SetUpSuite(c *C) {
 }
 
 func (s *HandlerSuite) TearDownSuite(c *C) {
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 }
 

api/service_consumption_test.go

@@ -38,7 +38,6 @@ func (s *ConsumptionSuite) SetUpSuite(c *C) {
 }
 
 func (s *ConsumptionSuite) TearDownSuite(c *C) {
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 }
 

api/service_provision_test.go

@@ -39,7 +39,6 @@ func (s *ProvisionSuite) SetUpSuite(c *C) {
 }
 
 func (s *ProvisionSuite) TearDownSuite(c *C) {
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 }
 

api/suite_test.go

@@ -107,7 +107,6 @@ func (s *S) SetUpSuite(c *C) {
 func (s *S) TearDownSuite(c *C) {
 	defer s.t.S3Server.Quit()
 	defer s.t.IamServer.Quit()
-	defer s.conn.Close()
 	queue.Preempt()
 	s.conn.Apps().Database.DropDatabase()
 	fsystem = nil

api/writer_test.go

@@ -29,7 +29,6 @@ func (s *WriterSuite) SetUpSuite(c *C) {
 }
 
 func (s *WriterSuite) TearDownSuite(c *C) {
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 }
 

app/suite_test.go

@@ -100,7 +100,6 @@ func (s *S) SetUpSuite(c *C) {
 func (s *S) TearDownSuite(c *C) {
 	defer s.t.S3Server.Quit()
 	defer s.t.IamServer.Quit()
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 	fsystem = nil
 	queue.Preempt()

auth/suite_test.go

@@ -84,7 +84,6 @@ func (s *S) SetUpSuite(c *C) {
 }
 
 func (s *S) TearDownSuite(c *C) {
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 }
 

collector/bench_test.go

@@ -56,7 +56,6 @@ func BenchmarkUpdate(b *testing.B) {
 	if err != nil {
 		panic(err)
 	}
-	defer conn.Close()
 	defer conn.Apps().Database.DropDatabase()
 	_, names := getFakeApps(conn)
 	app.Provisioner = ttesting.NewFakeProvisioner()

collector/suite_test.go

@@ -35,7 +35,6 @@ func (s *S) SetUpSuite(c *C) {
 
 func (s *S) TearDownSuite(c *C) {
 	s.conn.Apps().Database.DropDatabase()
-	s.conn.Close()
 }
 
 func (s *S) TearDownTest(c *C) {

db/storage.go

@@ -81,21 +81,6 @@ func Conn() (storage *Storage, err error) {
 	return Open(url, dbname)
 }
 
-// Close closes the connection.
-//
-// You can take advantage of defer statement, and write code that look like this:
-//
-//     st, err := Open("localhost:27017", "tsuru")
-//     if err != nil {
-//         panic(err)
-//     }
-//     defer st.Close()
-//
-// TODO(fss): remove this method and implement a "connection collector".
-func (s *Storage) Close() {
-	s.session.Close()
-}
-
 // Collection returns a collection by its name.
 //
 // If the collection does not exist, MongoDB will create it.

db/storage_test.go

@@ -50,7 +50,7 @@ var _ = Suite(&S{})
 func (s *S) TearDownSuite(c *C) {
 	storage, err := Open("127.0.0.1:27017", "tsuru_storage_test")
 	c.Assert(err, IsNil)
-	defer storage.Close()
+	defer storage.session.Close()
 	storage.session.DB("tsuru_storage_test").DropDatabase()
 }
 
@@ -61,21 +61,21 @@ func (s *S) TearDownTest(c *C) {
 func (s *S) TestOpenConnectsToTheDatabase(c *C) {
 	storage, err := Open("127.0.0.1:27017", "tsuru_storage_test")
 	c.Assert(err, IsNil)
-	defer storage.Close()
+	defer storage.session.Close()
 	c.Assert(storage.session.Ping(), IsNil)
 }
 
 func (s *S) TestOpenStoresConnectionInThePool(c *C) {
 	storage, err := Open("127.0.0.1:27017", "tsuru_storage_test")
 	c.Assert(err, IsNil)
-	defer storage.Close()
+	defer storage.session.Close()
 	c.Assert(storage.session, Equals, conn["127.0.0.1:27017"])
 }
 
 func (s *S) TestOpenReusesConnection(c *C) {
 	storage, err := Open("127.0.0.1:27017", "tsuru_storage_test")
 	c.Assert(err, IsNil)
-	defer storage.Close()
+	defer storage.session.Close()
 	storage2, err := Open("127.0.0.1:27017", "tsuru_storage_test")
 	c.Assert(err, IsNil)
 	c.Assert(storage.session, Equals, storage2.session)
@@ -84,7 +84,7 @@ func (s *S) TestOpenReusesConnection(c *C) {
 func (s *S) TestOpenReconnects(c *C) {
 	storage, err := Open("127.0.0.1:27017", "tsuru_storage_test")
 	c.Assert(err, IsNil)
-	storage.Close()
+	storage.session.Close()
 	storage, err = Open("127.0.0.1:27017", "tsuru_storage_test")
 	c.Assert(err, IsNil)
 	err = storage.session.Ping()
@@ -104,7 +104,7 @@ func (s *S) TestConn(c *C) {
 	defer config.Unset("database:name")
 	storage, err := Conn()
 	c.Assert(err, IsNil)
-	defer storage.Close()
+	defer storage.session.Close()
 	err = storage.session.Ping()
 	c.Assert(err, IsNil)
 }
@@ -125,35 +125,16 @@ func (s *S) TestConnMissingDatabaseName(c *C) {
 	c.Assert(err.Error(), Equals, `configuration error: key "database:name" not found`)
 }
 
-func (s *S) TestCloseClosesTheConnectionWithMongoDB(c *C) {
-	defer func() {
-		if r := recover(); r == nil {
-			c.Errorf("Should close the connection.")
-		}
-	}()
-	storage, _ := Open("127.0.0.1:27017", "tsuru_storage_test")
-	storage.Close()
-	err := storage.session.Ping()
-	c.Assert(err, NotNil)
-}
-
-func (s *S) TestCloseKeepsTheConnectionInThePool(c *C) {
-	storage, _ := Open("127.0.0.1:27017", "tsuru_storage_test")
-	storage.Close()
-	_, ok := conn["127.0.0.1:27017"]
-	c.Assert(ok, Equals, true)
-}
-
 func (s *S) TestCollection(c *C) {
 	storage, _ := Open("127.0.0.1:27017", "tsuru_storage_test")
-	defer storage.Close()
+	defer storage.session.Close()
 	collection := storage.Collection("users")
 	c.Assert(collection.FullName, Equals, storage.dbname+".users")
 }
 
 func (s *S) TestUsers(c *C) {
 	storage, _ := Open("127.0.0.1:27017", "tsuru_storage_test")
-	defer storage.Close()
+	defer storage.session.Close()
 	users := storage.Users()
 	usersc := storage.Collection("users")
 	c.Assert(users, DeepEquals, usersc)
@@ -162,7 +143,7 @@ func (s *S) TestUsers(c *C) {
 
 func (s *S) TestApps(c *C) {
 	storage, _ := Open("127.0.0.1:27017", "tsuru_storage_test")
-	defer storage.Close()
+	defer storage.session.Close()
 	apps := storage.Apps()
 	appsc := storage.Collection("apps")
 	c.Assert(apps, DeepEquals, appsc)
@@ -171,23 +152,23 @@ func (s *S) TestApps(c *C) {
 
 func (s *S) TestServices(c *C) {
 	storage, _ := Open("127.0.0.1:27017", "tsuru_storage_test")
-	defer storage.Close()
+	defer storage.session.Close()
 	services := storage.Services()
 	servicesc := storage.Collection("services")
 	c.Assert(services, DeepEquals, servicesc)
 }
 
 func (s *S) TestServiceInstances(c *C) {
 	storage, _ := Open("127.0.0.1:27017", "tsuru_storage_test")
-	defer storage.Close()
+	defer storage.session.Close()
 	serviceInstances := storage.ServiceInstances()
 	serviceInstancesc := storage.Collection("service_instances")
 	c.Assert(serviceInstances, DeepEquals, serviceInstancesc)
 }
 
 func (s *S) TestMethodTeamsShouldReturnTeamsCollection(c *C) {
 	storage, _ := Open("127.0.0.1:27017", "tsuru_storage_test")
-	defer storage.Close()
+	defer storage.session.Close()
 	teams := storage.Teams()
 	teamsc := storage.Collection("teams")
 	c.Assert(teams, DeepEquals, teamsc)

provision/juju/elb_test.go

@@ -55,7 +55,6 @@ func (s *ELBSuite) SetUpSuite(c *C) {
 func (s *ELBSuite) TearDownSuite(c *C) {
 	config.Unset("juju:use-elb")
 	s.conn.Collection("juju_units_test_elb").Database.DropDatabase()
-	s.conn.Close()
 	s.server.Quit()
 	handler.Stop()
 	handler.Wait()

provision/juju/suite_test.go

@@ -36,5 +36,4 @@ func (s *S) TearDownSuite(c *C) {
 	handler.Stop()
 	handler.Wait()
 	s.conn.Collection(s.collName).Database.DropDatabase()
-	s.conn.Close()
 }

service/bind/bind_test.go

@@ -47,7 +47,6 @@ func (s *S) SetUpSuite(c *C) {
 }
 
 func (s *S) TearDownSuite(c *C) {
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 }
 

service/suite_test.go

@@ -69,7 +69,6 @@ func (s *S) SetUpSuite(c *C) {
 }
 
 func (s *S) TearDownSuite(c *C) {
-	defer s.conn.Close()
 	s.conn.Apps().Database.DropDatabase()
 }