Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env var names should be sanitized #2144

Closed
ggarnier opened this issue Aug 30, 2018 · 0 comments · Fixed by #2150
Closed

Env var names should be sanitized #2144

ggarnier opened this issue Aug 30, 2018 · 0 comments · Fixed by #2150
Milestone

Comments

@ggarnier
Copy link
Member

Currently tsuru accepts env var names with characters like space:

tsuru env-set "  ENV   WITH    SPACES      "="value" -a <appname>

This is accepted on apps running with Docker cluster, but not with Kubernetes:

a valid environment variable name must consist of alphabetic characters, digits, '_', '-', or '.', and must not start with a digit (e.g. 'my.env-name',  or 'MY_ENV.NAME',  or 'MyEnvName1', regex used for validation is '[-._a-zA-Z][-._a-zA-Z0-9]*')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant