provision/docker: use credentials in healthcheck - #1969
Merged
Conversation
cezarsa
requested changes
Mar 20, 2018
| } | ||
| if len(credentials) > 0 { | ||
| b64 := base64.StdEncoding.EncodeToString([]byte(credentials)) | ||
| req.Header.Add("Authorization", "Basic "+b64) |
Member
There was a problem hiding this comment.
You can use req.SetBasicAuth() here instead of manually encoding the auth header.
ggarnier
force-pushed
the
registry-hc-with-auth
branch
from
March 20, 2018 21:21
dc2ab60 to
6093fab
Compare
guilhermebr
approved these changes
Mar 21, 2018
andrestc
approved these changes
Mar 21, 2018
Member
Author
|
Related to #1977 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.