New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provision/docker: use credentials in healthcheck #1969

Merged
merged 2 commits into from Mar 21, 2018

Conversation

Projects
None yet
4 participants
@ggarnier
Member

ggarnier commented Mar 19, 2018

No description provided.

}
if len(credentials) > 0 {
b64 := base64.StdEncoding.EncodeToString([]byte(credentials))
req.Header.Add("Authorization", "Basic "+b64)

This comment has been minimized.

@cezarsa

cezarsa Mar 20, 2018

Member

You can use req.SetBasicAuth() here instead of manually encoding the auth header.

This comment has been minimized.

@ggarnier

@ggarnier ggarnier merged commit 39544ac into tsuru:master Mar 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ggarnier ggarnier deleted the ggarnier:registry-hc-with-auth branch Mar 21, 2018

@ggarnier

This comment has been minimized.

Member

ggarnier commented Mar 23, 2018

Related to #1977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment