Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass region to cloudsearch client in Nazrin::DataAccessor::Struct #34

Merged
merged 1 commit into from Mar 11, 2019
Merged

Pass region to cloudsearch client in Nazrin::DataAccessor::Struct #34

merged 1 commit into from Mar 11, 2019

Conversation

AMHOL
Copy link
Contributor

@AMHOL AMHOL commented Mar 11, 2019

Previously this just relied on the AWS_REGION environment variable or config from ~/.aws/config

@AMHOL
Pass region to cloudsearch client in Nazrin::DataAccessor::Struct
c5a9948 
Previously this just relied on the AWS_REGION environment variable or config from ~/.aws/config
@tsuwatch tsuwatch self-requested a review March 11, 2019 06:54
tsuwatch
tsuwatch approved these changes Mar 11, 2019
View reviewed changes
Copy link
Owner

@tsuwatch tsuwatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Merging!

@tsuwatch tsuwatch merged commit a4b8f1f into tsuwatch:master Mar 11, 2019
@AMHOL AMHOL deleted the feature/configurable-region-for-struct-data-accessor branch March 11, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuwatch tsuwatch tsuwatch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AMHOL @tsuwatch