New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression 'a[value]' is not found in the localized string '${ a[value] } banana ${ b[value] }'. #90

Closed
MrOrz opened this Issue Jun 16, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@MrOrz
Contributor

MrOrz commented Jun 16, 2017

Seems that the current validateAndFormatMsgid does not support [] notations. The main reason is that we directly interpolate variable value when creating regular expressions. And new Regexp('a[value]') cannot match the string a[value].

Added failing test case:
MrOrz@dfdb5e1

Have not come up with a fix yet. Maybe we should not use regular expressions here...?

@AlexMost

This comment has been minimized.

Member

AlexMost commented Jun 16, 2017

thanks, will look at this issue soon.

@AlexMost

This comment has been minimized.

Member

AlexMost commented Jun 20, 2017

fixed in 0.5.7

@AlexMost AlexMost closed this Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment