Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

crash in handle_tracker_item - doesn't detect bad credentials. #4

Open
simsong opened this Issue Dec 7, 2012 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

simsong commented Dec 7, 2012

In this code:

            number = issue['number']
            print 'Attaching labels: %s' % labels
            rest_call('POST', 'issues/%s/labels' % (number), labels)
            for comment in comments:
                print 'Creating comment: %s' % comment[:50].replace('\n', ' ').replace(chr(13), '')
                rest_call('POST', 'issues/%s/comments' % (number), {'body': comment})
            if closed:
                print 'Closing...'
                rest_call('PATCH', 'issues/%s' % (number), {'state': 'closed'})

I'm having a crash because the dictionary issue does not have a field number. It has these values:

('no issue number: ', {u'message': u'Bad credentials'})

It should pick up Bad Credentials better?

Owner

ttencate commented Dec 7, 2012

It should. Feel free to send me a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment