Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

updated to work with github api v3 #3

Merged
merged 1 commit into from Aug 18, 2012

Conversation

Projects
None yet
2 participants
Contributor

fordfrog commented Aug 3, 2012

hi, i've just updated your script so that it works with github api v3 (as v2 is not supported anymore). because new api uses PATCH request method, i switched to requests python library. also, in some cases, github api responses with error 500 so i added condition that just prints out info that import of an issue failed and continues with import of following issues.

i do not code in python so maybe my patch could be written better, but at least it works for me.

thank you for the great script.

@ttencate ttencate added a commit that referenced this pull request Aug 18, 2012

@ttencate ttencate Merge pull request #3 from fordfrog/master
updated to work with github api v3
ba821d2

@ttencate ttencate merged commit ba821d2 into ttencate:master Aug 18, 2012

Owner

ttencate commented Aug 18, 2012

Thanks! The entire script is a "this just might work" thing, so don't worry about code quality. If it worked for you, it will probably work for other people. Otherwise, well, the old version didn't work for sure anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment