Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Small fixes #9

Merged
merged 2 commits into from

2 participants

@ockham

See commit messages!

ockham added some commits
@ockham ockham Simplify HTTPBasicAuth arguments.
This makes sf2github compatible with older python-requests
versions, such as 0.8.2 (shipped e.g. with Ubuntu 12.04).
a887c2b
@ockham ockham Remove obsolete imports. 49a6033
@ttencate ttencate merged commit f5842d5 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 18, 2013
  1. @ockham

    Simplify HTTPBasicAuth arguments.

    ockham authored
    This makes sf2github compatible with older python-requests
    versions, such as 0.8.2 (shipped e.g. with Ubuntu 12.04).
  2. @ockham

    Remove obsolete imports.

    ockham authored
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 7 deletions.
  1. +3 −7 issues.py
View
10 issues.py
@@ -28,13 +28,9 @@
trackers = soup.document.find('trackers', recursive=False).findAll('tracker', recursive=False)
-from urllib import urlencode
-from urllib2 import HTTPError
-from base64 import b64encode
from time import sleep
from getpass import getpass
import requests
-from requests.auth import HTTPBasicAuth
import json
import re
@@ -42,9 +38,9 @@ def __rest_call_unchecked(method, request, data=None):
global github_repo, github_user, github_password
url = 'https://api.github.com/repos/%s/%s' % (github_repo, request)
if method == 'PATCH':
- response = requests.patch(url, data=json.dumps(data), auth=HTTPBasicAuth(github_user, github_password))
+ response = requests.patch(url, data=json.dumps(data), auth=(github_user, github_password))
else:
- response = requests.post(url, data=json.dumps(data), auth=HTTPBasicAuth(github_user, github_password))
+ response = requests.post(url, data=json.dumps(data), auth=(github_user, github_password))
# GitHub limits API calls to 60 per minute
sleep(1)
return response
@@ -54,7 +50,7 @@ def rest_call(method, request, data=None):
while True:
try:
return __rest_call_unchecked(method, request, data)
- except HTTPError, e:
+ except requests.HTTPError, e:
print "Got HTTPError:", e
l = data_dict and max(map(len, data_dict.itervalues())) or 0
if e.code == 413 or l >= 100000: # Request Entity Too Large
Something went wrong with that request. Please try again.