Skip to content

Updated package.json to fix oauth beign a extraneous package#40

Closed
fmartingr wants to merge 1 commit into
ttezel:masterfrom
fmartingr:master
Closed

Updated package.json to fix oauth beign a extraneous package#40
fmartingr wants to merge 1 commit into
ttezel:masterfrom
fmartingr:master

Conversation

@fmartingr

Copy link
Copy Markdown

No description provided.

Fixes the extraneous oauth package
@ttezel

ttezel commented Feb 28, 2013

Copy link
Copy Markdown
Owner

The latest version of oauth on npm (v0.9.8 - the one you listed) has a bug in it - it fails to correctly encode data in the URL. So that's why I removed it from the package.json and added it as an entry in bundledDependencies.

@fmartingr

Copy link
Copy Markdown
Author

I used that version because is the one listed on npm ls.

The reason of having oauth as an actual dependence is that npm shrinkwrap don't work with extraneous deps, and is needed by my PaaS to work with (since uploading the app with the node_modules folder do not work).

And also, what are the problems that the bug on the 0.9.8 cause twit not to work correctly? My app works fine with the oauth from npm but I only use channel streaming.

Is the 0.9.8 bundled with twit patched?
Also, could you tell me the ticket number for the bug you mention? I want to have a look because the repo have not been updated in months. Maybe we can fork it and then use a git dependence instead of a NPM one.

Thanks for your time.

@kai-koch

kai-koch commented Mar 1, 2013

Copy link
Copy Markdown

#26

@ttezel

ttezel commented Mar 1, 2013

Copy link
Copy Markdown
Owner

@fmartingr as referenced in the issue @kai-koch linked to, posting tweets (and POST data in general) was buggy for characters requiring encoding. v0.9.8 of oauth is not up-to-date in npm. I'll create an issue on the node-oauth repo to try to convince the author to update the package on npm.

@ttezel

ttezel commented Mar 1, 2013

Copy link
Copy Markdown
Owner

This is the issue I posted: ciaranj/node-oauth#128 Feel free to comment with a +1 or something to show that it's urgent :)

@ttezel

ttezel commented Mar 1, 2013

Copy link
Copy Markdown
Owner

OK this is fixed and I published a new version of twit (v1.1.4) with oauth listed as a regular dependency. Run npm update twit to get it

@ttezel ttezel closed this Mar 1, 2013
@fmartingr

Copy link
Copy Markdown
Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants