{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":767544702,"defaultBranch":"master","name":"bpftrace","ownerLogin":"ttreyer","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-03-05T13:42:02.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/221672?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1720454633.0","currentOid":""},"activityList":{"items":[{"before":"93b2f8a4378094a17812c5f3825a9526dbb84f24","after":"0d84fcb3591cd73d2547d9d0c42bc1da4e6fc372","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-26T18:26:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"622c960abb21560fb4624fb1a0f5804766c5c588","after":"93b2f8a4378094a17812c5f3825a9526dbb84f24","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-11T21:48:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"3384d790dd60f27fb4acbda4072767a47167a502","after":"622c960abb21560fb4624fb1a0f5804766c5c588","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-11T14:42:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"26250bf672279bb842e1bc84ddded5ef6cc95610","after":"3384d790dd60f27fb4acbda4072767a47167a502","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-11T13:55:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"4bf7ff0ac58695800c865d9d4a4550480f7f7ef7","after":"3a58e80846a48671b80d373702ccb2a43702e603","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-11T12:09:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"kprobe inline function","shortMessageHtmlLink":"kprobe inline function"}},{"before":"1e4ebc6cb0251be11beff0ecb2f54f5c380f1c7f","after":"4bf7ff0ac58695800c865d9d4a4550480f7f7ef7","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-10T19:41:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"kprobe inline function","shortMessageHtmlLink":"kprobe inline function"}},{"before":"4fe5fa27234275d3c02c38c702dba1adb80b6a0e","after":"1e4ebc6cb0251be11beff0ecb2f54f5c380f1c7f","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-10T17:27:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"kprobe inline function","shortMessageHtmlLink":"kprobe inline function"}},{"before":"aa74bd35e643ee0dfac42a846c2c8594acb1d5ba","after":"4fe5fa27234275d3c02c38c702dba1adb80b6a0e","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-10T17:04:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"kprobe inline function","shortMessageHtmlLink":"kprobe inline function"}},{"before":"5db982b6c484cce107cde50919b84127ffa43624","after":"aa74bd35e643ee0dfac42a846c2c8594acb1d5ba","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-10T16:49:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"kprobe inline function","shortMessageHtmlLink":"kprobe inline function"}},{"before":"f8c1365e2d52f687d44f554a147a6ec97b747530","after":"5db982b6c484cce107cde50919b84127ffa43624","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-10T16:29:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"draft","shortMessageHtmlLink":"draft"}},{"before":"bfc9af7d1c37f8166e6239b60fd6789652763442","after":"f8c1365e2d52f687d44f554a147a6ec97b747530","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-10T13:52:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"draft3","shortMessageHtmlLink":"draft3"}},{"before":"52202e254df13edcacda9f2c5726175471d58864","after":"bfc9af7d1c37f8166e6239b60fd6789652763442","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-10T13:42:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"draft3","shortMessageHtmlLink":"draft3"}},{"before":"b256c55053242612feb052d37890a64115acdb86","after":"52202e254df13edcacda9f2c5726175471d58864","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-09T19:02:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"draft2","shortMessageHtmlLink":"draft2"}},{"before":"34a62c53f5873bd21392125cb8981310ab13a776","after":"b256c55053242612feb052d37890a64115acdb86","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-09T17:14:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"draft2","shortMessageHtmlLink":"draft2"}},{"before":"6302bdc3f0bf005293adbae78a5206c2def85647","after":"34a62c53f5873bd21392125cb8981310ab13a776","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-08T16:50:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"draft","shortMessageHtmlLink":"draft"}},{"before":null,"after":"6302bdc3f0bf005293adbae78a5206c2def85647","ref":"refs/heads/kprobe-inline","pushedAt":"2024-07-08T16:03:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"draft","shortMessageHtmlLink":"draft"}},{"before":null,"after":"fe9c5b46d95fbd157cb70f31beeced75cc1c8ac8","ref":"refs/heads/inline-kprobe","pushedAt":"2024-07-08T14:56:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Cleanups: Use \"const\" and reduce string copies","shortMessageHtmlLink":"Cleanups: Use \"const\" and reduce string copies"}},{"before":"ca1b216ba92d007c1aa4aa1e46aa6270c8caadaf","after":"fe9c5b46d95fbd157cb70f31beeced75cc1c8ac8","ref":"refs/heads/master","pushedAt":"2024-07-08T14:53:51.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Cleanups: Use \"const\" and reduce string copies","shortMessageHtmlLink":"Cleanups: Use \"const\" and reduce string copies"}},{"before":"41d93468c5c0cb6024b5726a85448303a6cda5b1","after":"26250bf672279bb842e1bc84ddded5ef6cc95610","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-04T13:45:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"725d358be0d7d921cf7f7bbe7ae8adfdc298859c","after":"41d93468c5c0cb6024b5726a85448303a6cda5b1","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-04T13:43:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"d40201e7963e0b2f638f88697d912491a6ac7bfd","after":"725d358be0d7d921cf7f7bbe7ae8adfdc298859c","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-02T13:03:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"65a08f4c38505d327862d52404be85469168966a","after":"ca1b216ba92d007c1aa4aa1e46aa6270c8caadaf","ref":"refs/heads/master","pushedAt":"2024-07-02T12:58:55.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"codegen: Fix segfault of CodegenLLVM::generateProbe()\n\nIf it is dummy, then the visit() operation should not be executed. For\nexample, on aarch64, there is no syscalls:sys_{enter,exit}_open\ntracepoint, however, opensnoop.bt tool will try to attch them and visit\nargs's field. We expect to get a warning, but instead we get a segmentation\nfault. As follows:\n\n    $ sudo gdb bpftrace\n    ...\n    (gdb) set args opensnoop.bt\n    (gdb) r\n    opensnoop.bt:22-24: WARNING: tracepoint not found: syscalls:sys_enter_open\n    opensnoop.bt:28-30: WARNING: tracepoint not found: syscalls:sys_exit_open\n\n    Thread 1 \"bpftrace\" received signal SIGSEGV, Segmentation fault.\n    0x000000000052bbd8 in __gnu_cxx::__normal_iterator<bpftrace::Field const*, std::vector<bpftrace::Field, std::allocator<bpftrace::Field> > >::__normal_iterator (this=0xffffffffb0b8, __i=<error reading variable: Cannot access memory at address 0x10>)\n        at /usr/include/c++/14/bits/stl_iterator.h:1068\n    1068              : _M_current(__i) { }\n    (gdb) bt\n    #0  0x000000000052bbd8 in __gnu_cxx::__normal_iterator<bpftrace::Field const*, std::vector<bpftrace::Field, std::allocator<bpftrace::Field> > >::__normal_iterator (this=0xffffffffb0b8,\n        __i=<error reading variable: Cannot access memory at address 0x10>) at /usr/include/c++/14/bits/stl_iterator.h:1068\n    #1  0x0000000000525bdc in std::vector<bpftrace::Field, std::allocator<bpftrace::Field> >::begin (this=0x10)\n        at /usr/include/c++/14/bits/stl_vector.h:884\n    #2  0x000000000059ce8c in bpftrace::Struct::GetField (this=0x0, name=\"filename\")\n        at /home/rongtao/Git/bpftrace/bpftrace/src/struct.cpp:131\n    #3  0x00000000005a70a0 in bpftrace::SizedType::GetField (this=0xe9b998, name=\"filename\")\n        at /home/rongtao/Git/bpftrace/bpftrace/src/types.cpp:538\n    #4  0x00000000007c7178 in bpftrace::ast::CodegenLLVM::visit (this=0xffffffffc650, acc=...)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:1973\n    #5  0x0000000000847db0 in bpftrace::ast::FieldAccess::accept (this=0xe9be30, v=...)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/ast.cpp:31\n    #6  0x00000000007d2404 in bpftrace::ast::CodegenLLVM::accept (this=0xffffffffc650, node=0xe9be30)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:3778\n    #7  0x00000000007c8bec in bpftrace::ast::CodegenLLVM::visit (this=0xffffffffc650, assignment=...)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:2218\n    #8  0x0000000000847eb4 in bpftrace::ast::AssignMapStatement::accept (this=0xffffe4429250, v=...)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/ast.cpp:36\n    #9  0x00000000007d2404 in bpftrace::ast::CodegenLLVM::accept (this=0xffffffffc650, node=0xffffe4429250)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:3778\n    #10 0x00000000007ca4c4 in bpftrace::ast::CodegenLLVM::generateProbe (this=0xffffffffc650, probe=..., full_func_id=\"dummy\",\n        name=\"dummy\", func_type=0xff2b50, usdt_location_index=std::optional [no contained value], dummy=true)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:2539\n    #11 0x00000000007cb4e4 in bpftrace::ast::CodegenLLVM::visit (this=0xffffffffc650, probe=...)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:2734\n    #12 0x00000000008480f0 in bpftrace::ast::Probe::accept (this=0xffffe4427650, v=...)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/ast.cpp:47\n    #13 0x00000000007d2404 in bpftrace::ast::CodegenLLVM::accept (this=0xffffffffc650, node=0xffffe4427650)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:3778\n    #14 0x00000000007cb7a4 in bpftrace::ast::CodegenLLVM::visit (this=0xffffffffc650, program=...)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:2752\n    #15 0x000000000084818c in bpftrace::ast::Program::accept (this=0xe90f50, v=...)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/ast.cpp:50\n    #16 0x00000000007d2404 in bpftrace::ast::CodegenLLVM::accept (this=0xffffffffc650, node=0xe90f50)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:3778\n    #17 0x00000000007d03fc in bpftrace::ast::CodegenLLVM::generate_ir (this=0xffffffffc650)\n        at /home/rongtao/Git/bpftrace/bpftrace/src/ast/passes/codegen_llvm.cpp:3450\n    #18 0x0000000000478138 in main (argc=2, argv=0xfffffffff4c8) at /home/rongtao/Git/bpftrace/bpftrace/src/main.cpp:898\n\nWe can simplify opensnoop.bt to:\n\n    tracepoint:syscalls:sys_enter_open_not_exist,\n    tracepoint:syscalls:sys_enter_openat\n    {\n        @ = args.filename;\n    }\n\nThis will produce the following error:\n\n    stdin:1:1-45: WARNING: tracepoint not found: syscalls:sys_enter_open_not_exist\n    tracepoint:syscalls:sys_enter_open_not_exist,tracepoint:syscalls:sys_enter_openat {@ = args.filename;}\n    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n    Segmentation fault\n\nWe need to generate the dummy probe only for cases when none of the probe\nattach points exists.\n\nLink: https://github.com/bpftrace/bpftrace/pull/3274\nSigned-off-by: Viktor Malik <viktor.malik@gmail.com>\nSigned-off-by: Rong Tao <rongtao@cestc.cn>","shortMessageHtmlLink":"codegen: Fix segfault of CodegenLLVM::generateProbe()"}},{"before":"f630bbe110554a311df166936aa9e35810ee683f","after":"d40201e7963e0b2f638f88697d912491a6ac7bfd","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-02T11:12:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"7cfef193515ca46851f3c4eab811d3b37d4a1f77","after":"f630bbe110554a311df166936aa9e35810ee683f","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-07-01T16:31:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"1e6115bfebf7cdb4e02847ae50a371d63259780d","after":"7cfef193515ca46851f3c4eab811d3b37d4a1f77","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-06-26T15:50:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"c84b6ed002f869c347f3fc4076a6f14aab3560af","after":"1e6115bfebf7cdb4e02847ae50a371d63259780d","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-06-26T14:03:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"5fb066f3527c6bff819d9207ff985be2a196156f","after":"c84b6ed002f869c347f3fc4076a6f14aab3560af","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-06-26T13:59:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"88c8dc1eb5b66cb60321f19347a3ba28ef479474","after":"5fb066f3527c6bff819d9207ff985be2a196156f","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-06-25T18:27:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"8ced258e07a91212c1cd84a2371ed642638d0b9d","after":"88c8dc1eb5b66cb60321f19347a3ba28ef479474","ref":"refs/heads/cxx-inheritance","pushedAt":"2024-06-25T13:56:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix ProbeMatcher for uprobeArray","shortMessageHtmlLink":"Fix ProbeMatcher for uprobeArray"}},{"before":"5b6013d1711f609f89f9b1b542708a9e87a1e6c8","after":"65a08f4c38505d327862d52404be85469168966a","ref":"refs/heads/master","pushedAt":"2024-06-25T12:03:05.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"ttreyer","name":"Thierry Treyer","path":"/ttreyer","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/221672?s=80&v=4"},"commit":{"message":"Fix some C++ warnings found by clang\n\n* Cleanup: don't mix designated and non-designated initializers\r\n\r\nClang rightfully complains with \"warning: mixture of designated and\r\nnon-designated initializers in the same initializer list is a C99\r\nextension [-Wc99-designator]\". Let's just be consistent.\r\n\r\n* Cleanup: remove unnecessary std::move\r\n\r\nClang complains about an unnecessary std::move with \"warning: moving a\r\ntemporary object prevents copy elision [-Wpessimizing-move]\".\r\nIndeed there is no need for an explicit move here.\r\n\r\n* Cleanup: replace VLAs with std::string & std::vector\r\n\r\nC++ never standardized VLAs and while both gcc and clang can sort-of\r\nhandle them, using them with non-constexpr size arguments rightfully\r\nalerts the compiler police. For safety reasons we can just use plain\r\nstrings & vectors. None of the allocations are in performance-critical\r\npaths.\r\n\r\n---------\r\n\r\nCo-authored-by: Alastair Robertson <ajor@meta.com>","shortMessageHtmlLink":"Fix some C++ warnings found by clang"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEik2bZwA","startCursor":null,"endCursor":null}},"title":"Activity · ttreyer/bpftrace"}