Timeout option is mentioned in docs but isn't supported in the code #3

Closed
vvolodin opened this Issue Jul 3, 2013 · 5 comments

Comments

Projects
None yet
5 participants
@vvolodin

vvolodin commented Jul 3, 2013

Hi, your readme mentions timeout option to automatically close notifications but it doesn't work.

@ghost ghost assigned ttsvetko Jul 3, 2013

@ttsvetko

This comment has been minimized.

Show comment
Hide comment
@ttsvetko

ttsvetko Jul 3, 2013

Owner

autoClose option is a little bit tricky... It is set to 0 by default, which means it has no affect and notifications are closed automatically(depends on browsers implementations and MacOS Notification Center settings).

autoClose has no effect for IE - hiding notifications(removing icon and stop highlighting the taskbar button) after few seconds may prevent users from seeing the notification - they may missed it. Plus, in IE could be displayed one notification only. So, in your code you can close the notification manually when user reacts on the notification - for example - if you display notification for incoming call or new chat message received, when user answer/decline or click on the chat message you can call close method of the notification object returned when create is called.

autoClose seems to work fine in Firefox(Win/MacOs)(just fixed it for Firefox - please download the lastest version of the code) and Chrome(Win).
Chrome on MacOS and Safari do not close notification although close method is called - seems to be issue or may be desired behaviour as notifications are integrated with Notification Center on MacOS.

Owner

ttsvetko commented Jul 3, 2013

autoClose option is a little bit tricky... It is set to 0 by default, which means it has no affect and notifications are closed automatically(depends on browsers implementations and MacOS Notification Center settings).

autoClose has no effect for IE - hiding notifications(removing icon and stop highlighting the taskbar button) after few seconds may prevent users from seeing the notification - they may missed it. Plus, in IE could be displayed one notification only. So, in your code you can close the notification manually when user reacts on the notification - for example - if you display notification for incoming call or new chat message received, when user answer/decline or click on the chat message you can call close method of the notification object returned when create is called.

autoClose seems to work fine in Firefox(Win/MacOs)(just fixed it for Firefox - please download the lastest version of the code) and Chrome(Win).
Chrome on MacOS and Safari do not close notification although close method is called - seems to be issue or may be desired behaviour as notifications are integrated with Notification Center on MacOS.

@chrisgraham

This comment has been minimized.

Show comment
Hide comment
@chrisgraham

chrisgraham Aug 11, 2013

The original poster is referring to your naming. You literally refer to an option named 'timeout', but it is actually 'autoClose' in your code.

A nice auto-close implementation for IE is to attach an event to window.onfocus. It's slightly different of course, but works well (if the bug I am about to post about is fixed...).

The original poster is referring to your naming. You literally refer to an option named 'timeout', but it is actually 'autoClose' in your code.

A nice auto-close implementation for IE is to attach an event to window.onfocus. It's slightly different of course, but works well (if the bug I am about to post about is fixed...).

@grjones

This comment has been minimized.

Show comment
Hide comment
@grjones

grjones Jan 23, 2014

Firefox 26 on OSX seems to close the notification regardless of the set autoClose value. Is anyone else seeing this behavior?

grjones commented Jan 23, 2014

Firefox 26 on OSX seems to close the notification regardless of the set autoClose value. Is anyone else seeing this behavior?

@sandeep-pareek

This comment has been minimized.

Show comment
Hide comment
@sandeep-pareek

sandeep-pareek Aug 2, 2016

Setting autoClose = 0 don't have any effect. Even if I set it to 0, the notification does close. I want notification to stay up as long as user cancels it or she follows the link inside it. Am I missing anything or shall I file a new bug?

Setting autoClose = 0 don't have any effect. Even if I set it to 0, the notification does close. I want notification to stay up as long as user cancels it or she follows the link inside it. Am I missing anything or shall I file a new bug?

@ttsvetko

This comment has been minimized.

Show comment
Hide comment
@ttsvetko

ttsvetko Sep 12, 2016

Owner

released new version. AutoClose option is removed as it is already not supported

Owner

ttsvetko commented Sep 12, 2016

released new version. AutoClose option is removed as it is already not supported

@ttsvetko ttsvetko closed this Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment