Flexfix only PR #30

Closed
wants to merge 19 commits into
from

Projects

None yet

2 participants

@futtta
futtta commented May 27, 2016

As requested by @damienmckenna in issue (#26 (comment)).

@futtta
futtta commented May 27, 2016

not the git(hub)-expert, so lots of reverts + juggling spaces & tabs to have the smallest diff possible, hope all is OK this way.

@glensc
Contributor
glensc commented Nov 25, 2016

superseded by #32, @tubalmartin please merge #32
@futtta plz close this one

@futtta
futtta commented Nov 25, 2016

@glensc there's more in this then just #30

@glensc
Contributor
glensc commented Nov 25, 2016 edited

@futtta no it's not:
https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/pull/30/files

you reverted all other changes.

and anyway you should make 1 PR per 1 feature/fix.

plus i added test for your changes in #32

if you look #32 you will see i squashed your commits and added second commit for tests:
https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/pull/32/commits

so it covers #30 in a way that is mergeable

@futtta
futtta commented Nov 25, 2016

who'd have thunk, you're right! ;-)

@futtta futtta closed this Nov 25, 2016
@glensc
Contributor
glensc commented Nov 25, 2016

thunk? you mean 'thought'?

@futtta futtta deleted the futtta:flexfix branch Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment