Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiing flexbox percentage remove problem #26 #32

Closed
wants to merge 2 commits into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Nov 7, 2016

As requested by @damienmckenna in issue (#26 (comment)).

supersedes #30 by @futtta

  • squashes change to single commit.
  • adds test for this problem.

NOTE: this fix is still needed for MSIE 10-12

pld-gitsync pushed a commit to pld-linux/php-yui-css-compressor that referenced this pull request Nov 7, 2016
@glensc
Copy link
Contributor Author

glensc commented Nov 7, 2016

@tubalmartin do you still maintain this project?

@glensc glensc mentioned this pull request Nov 25, 2016
@glensc
Copy link
Contributor Author

glensc commented Dec 6, 2016

@tubalmartin give someone developer privileges if you're that busy. you can consider me.

@futtta
Copy link

futtta commented Dec 6, 2016

I second @glensc 's proposal, we need someone who can keep tabs on stuff!

@glensc
Copy link
Contributor Author

glensc commented Apr 3, 2017

@tubalmartin err, why you just closed this PR with no explanation or changes?

@tubalmartin
Copy link
Owner

Sorry for that, last week or so I released a version that fixed this, and I'm about to release v3 which takes care of this too.

@glensc
Copy link
Contributor Author

glensc commented Apr 3, 2017

don't forget to cherry-pick the tests i added to this PR.

@tubalmartin
Copy link
Owner

This is fixed in v2.4.8-p10 and v3.0.0. Enjoy!

@glensc
Copy link
Contributor Author

glensc commented Apr 4, 2017

crazy how you update this repository. can not understand anything if you just upload dozen of changes with same commit. git is not ftp :)

@tubalmartin
Copy link
Owner

It's been quite a rewrite, not a patch ;)

@tubalmartin
Copy link
Owner

But I see no real issue trying to figure out the changes I've done from previous versions to v2.4.8-p10 for example. Check this out: e53c4d1#diff-80f11f7052c350cef68c3041a5479789

v3.0.0 is a different story since that is almost a complete rewrite.

@glensc
Copy link
Contributor Author

glensc commented Apr 4, 2017

i can't make heads or tails of the huge commit. i'll just assume you applied fix and added test.

and even complete rewrite can be achieved normally with normal commits not single commit replacing everything.

let it be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants