Skip to content

Fix URL params in embed player #907#914

Merged
MerlinScheurer merged 1 commit into
tubearchivist:testingfrom
masonjames:url-params
Mar 29, 2025
Merged

Fix URL params in embed player #907#914
MerlinScheurer merged 1 commit into
tubearchivist:testingfrom
masonjames:url-params

Conversation

@masonjames

Copy link
Copy Markdown
Contributor

When opening/closing embedded videos, maintain existing URL parameters including pagination state. Previously, the video player would reset page to 0 and lose other query parameters.

When opening/closing embedded videos, maintain existing URL parameters including pagination state. Previously, the video player would reset page to 0 and lose other query parameters.
@MerlinScheurer

MerlinScheurer commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

Looks good!
But you don't need to create a new URLSearchParams instance every time.
You can just modify the params ( https://api.reactrouter.com/v7/types/react_router.SetURLSearchParams.html )

#907

@MerlinScheurer MerlinScheurer changed the base branch from master to testing March 29, 2025 08:25
@MerlinScheurer MerlinScheurer changed the base branch from testing to master March 29, 2025 08:26
@MerlinScheurer MerlinScheurer changed the base branch from master to testing March 29, 2025 09:28
@MerlinScheurer MerlinScheurer changed the title Fix URL params in embed player Fix URL params in embed player #907 Mar 29, 2025
@MerlinScheurer MerlinScheurer merged commit a2cb2d2 into tubearchivist:testing Mar 29, 2025
@bbilly1 bbilly1 mentioned this pull request Mar 30, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants