Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Exposing EBML Parsing Logic #1

Closed
brycefisher opened this issue Jan 8, 2018 · 1 comment
Closed

Consider Exposing EBML Parsing Logic #1

brycefisher opened this issue Jan 8, 2018 · 1 comment

Comments

@brycefisher
Copy link

@brycefisher brycefisher commented Jan 8, 2018

I'm trying to parse matroska containers to get at the encoded video bitstreams within the file. It seems like this library doesn't expose any of the element sizes or byte offsets, and that doing so would probably defeat the purpose of this library.

Would you be open to receiving a PR to:

  1. separate out the EBML parsing bits into a separate crate, OR
  2. publicly reexport the ebml.rs functionality so that I could consume it directly as part of this crate

I'm guessing that work is fairly trivial, and if you're willing to accept a PR for one of these approaches, I'd being to dedicate an hour or two towards making that happen. (Also, I totally understand if this is not in the direction you want to go here.) Thanks!!

@brycefisher
Copy link
Author

@brycefisher brycefisher commented Jan 9, 2018

Actually, after looking at the mkv crate, it seems like this library does exactly what I'm looking for already. I'm going to close this issue in favor of using that library.

@brycefisher brycefisher closed this Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant