Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux support #504

Open
wants to merge 11 commits into
base: master
from
Open

Add Linux support #504

wants to merge 11 commits into from

Conversation

@pepibumur
Copy link
Contributor

pepibumur commented Nov 12, 2019

No description provided.

@pepibumur pepibumur requested a review from tuist/core Nov 12, 2019
@pepibumur pepibumur self-assigned this Nov 12, 2019
@pull-assigner pull-assigner bot requested review from kwridan and marciniwanicki and removed request for tuist/core Nov 12, 2019
@pepibumur pepibumur marked this pull request as ready for review Nov 12, 2019
@pepibumur pepibumur changed the title Add Linux support [WIP] Add Linux support Nov 12, 2019
@pepibumur pepibumur force-pushed the linux-support branch from cb9b8cc to 335df41 Nov 12, 2019
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Nov 12, 2019

@pepibumur your pull request is missing a changelog!

@pepibumur pepibumur mentioned this pull request Nov 12, 2019
0 of 3 tasks complete
@yonaskolb

This comment has been minimized.

Copy link
Collaborator

yonaskolb commented Nov 12, 2019

Interesting. Do we need to remove the auto generated equatable code? How is that affecting Linux? Would be shame to have to update those all by hand when making changes

@yonaskolb

This comment has been minimized.

Copy link
Collaborator

yonaskolb commented Nov 12, 2019

Ah, I see because of NSObject and @objc. We could have a custom Sourcery template then

@pepibumur

This comment has been minimized.

Copy link
Contributor Author

pepibumur commented Nov 13, 2019

I removed the autogenerated code and moved it to each individual object. I purposely removed the dependency with Sourcery to keep the project as lean as possible. Forgetting to run Sourcery and not adding new properties to the isEqual method result in the same thing so I'd rather not add the tool.

@pepibumur pepibumur changed the title [WIP] Add Linux support Add Linux support Nov 13, 2019
@pepibumur pepibumur force-pushed the linux-support branch from 83d196a to 9f990be Nov 13, 2019
@pepibumur

This comment has been minimized.

Copy link
Contributor Author

pepibumur commented Nov 13, 2019

The package is building in Linux and tests are running. The last part missing is is adding all the tests to the XCTestManifest file. If all the tests run successfully, I think we are good to merge this PR.

@yonaskolb

This comment has been minimized.

Copy link
Collaborator

yonaskolb commented Nov 13, 2019

@pepibumur swift test --generate-linuxmain

@pepibumur

This comment has been minimized.

Copy link
Contributor Author

pepibumur commented Nov 13, 2019

@pepibumur swift test --generate-linuxmain

🤯 Danke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.