Add the option to enable/disable the main thread checker from the generated schemes #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
requested review from
andreacipriani and
natanrolnik
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #1382 +/- ##
==========================================
+ Coverage 75.08% 75.11% +0.03%
==========================================
Files 317 318 +1
Lines 10391 10418 +27
==========================================
+ Hits 7802 7826 +24
- Misses 2589 2592 +3
Continue to review full report at Codecov.
|
andreacipriani
approved these changes
May 27, 2020
| @@ -269,6 +278,7 @@ final class SchemesGenerator: SchemesGenerating { | |||
|
|
|||
| let onlyGenerateCoverageForSpecifiedTargets = codeCoverageTargets.count > 0 ? true : nil | |||
|
|
|||
| let disableMainThreadChecker = !testAction.diagnosticsOptions.contains(.mainThreadChecker) | |||
There was a problem hiding this comment.
I thought about using the affermative (enable) instead of negative (disable) disableMainThreadChecker -> isMainThreadCheckerEnabled since I think that's more readable. But I see that's the name used in the XCScheme
There was a problem hiding this comment.
disableMainThreadChecker is how Xcode calls the attribute 😛 . That's why I took the opportunity to make it positive from our API . mainThreadChecker
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1321
Short description 📝
As @gbasile pointed out here we are enabling the main thread checker by default. This PR adds a new API to the
RunActionandTestActionmodel to set diagnostics options.