New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sudo requirement from install & uninstall scripts #3056
Conversation
eb79832
to
7ceee72
Compare
Do we know why |
@fortmarek Im not entirely sure! @pepibumur would you have more context? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this being merged but I would very much curious why it was there in the first place cc @pepibumur
@luispadron I remember having issues when running the installation scripts in M1. It'd be great if the scripts could be tested in that environment. If they work I think it's ok to merge this PR. |
This is a bit of a blocker for some to even use Tuist. For instance, in our environment
|
This is unfortunate! I agree it'd be much better if we got around using
yeah, I'm not sure how often Before merging this, we need someone to test this on M1. @luispadron is currently on vacation, but I believe he should return back soon-ish, so we can move forward with this afterwards. |
I can test this one on M1 and merge it if everything works as expected. |
7ceee72
to
fd073d7
Compare
I confirm this works successfully on M1 so I'll go ahead and merge the PR. |
Resolves #2806
Request for comments document (if applies):
Short description π
This PR removes the need to require sudo access. This is problematic in contexts where TTY is not available to enter password (such as in CI/CD). This also makes it more clear that the install script isn't doing anything crazy on someones machine that would require sudo.
Checklist β
CHANGELOG.md
has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.