Skip to content

Meta Tuist #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 20, 2021
Merged

Meta Tuist #3103

merged 20 commits into from
Jul 20, 2021

Conversation

fortmarek
Copy link
Member

@fortmarek fortmarek commented Jun 24, 2021

Short description 📝

Depends on this PR.

I have defined the rest of the modules. For now all of them are as .framework - if we wanted to vendor tuist with tuist, we'd need to change most of the targets to being static (but the current setup works for local development).

We will have to keep Package.swift as other projects might still rely on it if they don't use tuist executable directly.

I have yet to update the documentation for the contributors to nudge them to use it instead of working with the SPM project.

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested following the documented guidelines.
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.

@fortmarek fortmarek force-pushed the dog_food branch 2 times, most recently from eb94ae3 to 25235dc Compare July 18, 2021 08:44
@fortmarek fortmarek marked this pull request as ready for review July 18, 2021 14:31
@fortmarek fortmarek requested review from pepicrft and luispadron July 18, 2021 14:31
@fortmarek fortmarek requested a review from laxmorek July 18, 2021 17:55
Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @fortmarek 😍😍😍

@fortmarek fortmarek merged commit 370d9d0 into main Jul 20, 2021
@fortmarek fortmarek deleted the dog_food branch July 20, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants