Repository navigation
Conversation
fortmarek
force-pushed
the
dog_food
branch
2 times, most recently
from
July 18, 2021 08:44
eb94ae3 to
25235dc
Compare
fortmarek
marked this pull request as ready for review
July 18, 2021 14:31
pepicrft
approved these changes
Jul 18, 2021
pepicrft
left a comment
pepicrft
left a comment
Contributor
There was a problem hiding this comment.
This is awesome @fortmarek 😍😍😍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description 📝
Depends on this PR.
I have defined the rest of the modules. For now all of them are as
.framework- if we wanted to vendor tuist with tuist, we'd need to change most of the targets to being static (but the current setup works for local development).We will have to keep
Package.swiftas other projects might still rely on it if they don't use tuist executable directly.I have yet to update the documentation for the contributors to nudge them to use it instead of working with the SPM project.
Checklist ✅
CHANGELOG.mdhas been updated to reflect the changes. In case of a breaking change, it's been flagged as such.