🚀 Improve cache warm performances by not recompiling already in-cache targets #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
approved these changes
Nov 14, 2021
# Conflicts: # Sources/ProjectDescription/Dependencies/SwiftPackageManagerDependencies.swift
|
@danyf90 as commented offline I just pushed the fix for the logic, this should now work fine :) It would be great if you could try out a bit with your project! (I didn't update the tests) |
|
Looks like it's working great 😍 |
pepicrft
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for building the cache is to just prune the graph and build the required targets, but it doesn't replace dependencies with their cached artifact, even if already available.
Resurrection of #2404 and #2377. Now that we are pushing for caching, and especially remote one (which means we would probably compile those from scratch and we might not have their derived data), it is becoming more important to have this behavior