Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate settings attribute when compiler flags are not specified #415

Conversation

marciniwanicki
Copy link
Collaborator

Resolves #414

BuildPhaseGenerator will not generate empty settings attribute for source PBXBuildFile elements when compiler flags are not specified.

Test Plan:

  • Close Xcode
  • Generate fixtures/ios_app_with_frameworks fixture
  • Open generated .xcodeproj in a non-Xcode editor (i..e vim), ensure empty settings ={} attributes have not been generated

@tuistbot
Copy link
Contributor

tuistbot commented Jun 18, 2019

1 Warning
⚠️ Have you introduced any user-facing changes? If so, please take some time to update the documentation. Keeping the documentation up to date makes it easier for users to learn how to use Tuist.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #415 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #415      +/-   ##
=========================================
+ Coverage   92.29%   92.3%   +0.01%     
=========================================
  Files         293     293              
  Lines       15048   15071      +23     
=========================================
+ Hits        13888   13911      +23     
  Misses       1160    1160
Impacted Files Coverage Δ
...atorTests/Generator/BuildPhaseGeneratorTests.swift 100% <100%> (ø) ⬆️
...TuistGenerator/Generator/BuildPhaseGenerator.swift 97.54% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53cc082...aac500c. Read the comment docs.

Copy link
Collaborator

@ollieatkinson ollieatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗝

Looks good to me, I no longer see empty settings

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marciniwanicki marciniwanicki merged commit 6a9594e into tuist:master Jun 18, 2019
@marciniwanicki
Copy link
Collaborator Author

Many thanks @ollieatkinson and @kwridan 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty settings attribute in sources
4 participants