Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BL-1204 Update qa workflow. #196

Merged
merged 1 commit into from Jun 9, 2020

Conversation

dkinzer
Copy link
Member

@dkinzer dkinzer commented Jun 8, 2020

  • Deploy to qa on merges to master branch.
  • Deploy to production on release.
  • Keeps requires approval for deploys (Further guards against unintentional deploys).

* Deploy to qa on merges to master branch.

Deploy to production on release (plus approval?)
@dkinzer dkinzer marked this pull request as ready for review June 9, 2020 13:36
@bibliotechy
Copy link
Contributor

bibliotechy commented Jun 9, 2020

@dkinzer this looks like it is going to trigger a request for prod deploy on updates to master, which does not seem like what we want.

- request-prod-deploy:
type: approval
requires:
- lint_and_test
filters:
branches:
only:
- master

@dkinzer
Copy link
Member Author

dkinzer commented Jun 9, 2020

@bibliotechy I believe Christina added that. This update doesn't actually make changes to that step. However, that step doesn't do anything on its own. I guess because of the fact that it's a type: approval thing.

It will only get triggered by prod_deploy workflow which has that approval as a requirement.

@bibliotechy
Copy link
Contributor

@dkinzer So every merge to master is going to trigger an approval for prod deploy that just sits there?

@bibliotechy bibliotechy merged commit 02ae87c into master Jun 9, 2020
@bibliotechy bibliotechy deleted the bl-1203-bl-1204-update-to-be-master branch June 9, 2020 20:10
@dkinzer
Copy link
Member Author

dkinzer commented Jun 9, 2020

@bibliotechy I don't think so. I have not noticed that anyway. And that config's basically been there since we started using circleci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants