From a6f60ad72a262570ef04f290175687274b67e8fa Mon Sep 17 00:00:00 2001 From: Tommy Brunn Date: Tue, 26 Jul 2022 10:23:50 +0200 Subject: [PATCH] Verify creating topic with manual replica assignment Fixes #1162 --- src/admin/__tests__/createTopics.spec.js | 12 ++++++++++++ types/index.d.ts | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/admin/__tests__/createTopics.spec.js b/src/admin/__tests__/createTopics.spec.js index b05a313a6..db5080542 100644 --- a/src/admin/__tests__/createTopics.spec.js +++ b/src/admin/__tests__/createTopics.spec.js @@ -93,6 +93,18 @@ describe('Admin', () => { ).resolves.toEqual(true) }) + test('creating topic with manual replica assignment', async () => { + admin = createAdmin({ cluster: createCluster(), logger: newLogger() }) + + await admin.connect() + await expect( + admin.createTopics({ + waitForLeaders: false, + topics: [{ topic: topicName, replicaAssignment: [{ partition: 0, replicas: [0, 1] }] }], + }) + ).resolves.toEqual(true) + }) + test('retries if the controller has moved', async () => { const cluster = createCluster() const broker = { createTopics: jest.fn(() => true) } diff --git a/types/index.d.ts b/types/index.d.ts index b4b7efb60..c046a0188 100644 --- a/types/index.d.ts +++ b/types/index.d.ts @@ -238,7 +238,7 @@ export interface ITopicConfig { topic: string numPartitions?: number replicationFactor?: number - replicaAssignment?: object[] + replicaAssignment?: ReplicaAssignment[] configEntries?: IResourceConfigEntry[] }