Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Dominos & Masque - Weird extra backdrop #78

Closed
sp00n opened this Issue · 6 comments

3 participants

@sp00n

I'm having a weird bug with Dominos & Masque and am not sure which of both addons actually is the reason for it, so I'm posting this for both.

When I use Masque in combination with Dominos, I'm seeing a second kind of backdrop for some of the bars. These bars seem to be 3-6, the rest of the action bars appear as they should, e.g. no extra backdrop.
The backdrop even shows if I tick the "Disable" checkbox in Masque options.

I've updated both addons today (2011-11-30), but have seen this already on the PTR as well. I've also disabled every other addon and confirmed that this behavior only appears if both Dominos and Masque are loaded. Active addons were: Dominos, Dominos Config, Masque, all embedded libs. No other skins or addons.

Please see the screenshots for a visual presentation. The first is with Masque not loaded, the second with Masque loaded but disabled, and the third with Masque loaded and active (set to Dream or Zoomed, can't remember exactly which).

Masque not loaded
Masque not loaded

Masque loaded but disabled
Masque loaded but disabled

Masque loaded and active
Masque loaded and active

@Tuller
Owner

Two bits of background information:
With WoW 4.3, Blizzard decided to get rid of the old background on all empty action button slots, and instead give a new, darker background to the multi action button slots.

Without Masque loaded, Dominos slightly alters the look of action buttons. In 4.3, I added code to hide the multi action button background to the routine that performs the alteration.

With Masque loaded, I assume that Masque will handle this, since it can definitely affect things other than Dominos (like the standard action bars).

@StormFX

Is there a way you can hide this (if Masque is loaded) or pass it in the ButtonData table (as FloatingBG) so Masque can? Dominos is the only add-on having this problem that I've seen so far. Not sure what the others are doing. I need to go through the diff files and see what all's been altered. >.<

@Tuller
Owner
@StormFX

Well, since it is a part of that particular "type" of a button, it may actually a better idea for you to pass it in the ButtonData table (with the key 'FloatingBG') (assuming you're using the ButtonData table). Then, I can use that texture object as the actual background layer for those buttons and hide it based on the user's settings. That would eliminate quite a bit of texture creation on Masque's side.

@Tuller
Owner

I really think i should be another default for button data:

FloatingBG
The texture that's shown behind multi action buttons:

Default

_G[Button:GetName() .."FloatingBG"]

@StormFX

Er... That's what I saying. :p I'll get into the next beta.

@Tuller Tuller was assigned
@Tuller Tuller closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.