Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch and build TCC from github repository #125

Merged
merged 8 commits into from
Dec 15, 2022
Merged

Conversation

JoGei
Copy link
Member

@JoGei JoGei commented Dec 9, 2022

Addresses issue #108

TODO:

  • Decide which commit of TCC should be used, Tested with latest commit to their main branch mop
  • Fix CI Test steps?
  • Decide whether we want to make "fetch+build TCC" work for Windows host. won't fix thanks for not asking.

@JoGei JoGei requested a review from wysiwyng December 12, 2022 13:50
@JoGei JoGei marked this pull request as ready for review December 12, 2022 13:50
@JoGei
Copy link
Member Author

JoGei commented Dec 12, 2022

Got to make the build work again for Ubuntu-latest, aka 22. In case of Unix, TCC is now fetched from maintained repos, while Windows still uses the old one. If we want to make it work for Windows, some form of MinGW would be necessary as explained in TCC sources.

Biggest problem with our current flow is, IMHO, that the RegisterJITfile macro requires existing files during CMake configuration. Because of this I had to run the build steps for TCC during configuration as execute_process instead of having them be part of the usual CMake build process. This feels a bit hacky, but works.

This PR fails CI, because of "Linux Test" which requires Boost libraries to be present of which I am not sure how they could be if "Requirements" are not run before the test jobs. As far as I understand the CI, only the packaged etiss working directory is transferred from build to test(?).

@wysiwyng wysiwyng merged commit 8e4f68e into tum-ei-eda:master Dec 15, 2022
@JoGei JoGei deleted the fix_tcc branch February 23, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants