Ensure that we build only with java 1.7 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roymarantz
reviewed
Sep 26, 2016
| @@ -14,7 +14,7 @@ RUN apt-get update && \ | |||
| unzip -q ./activator.zip && \ | |||
| cd collins && \ | |||
| java -version 2>&1 && \ | |||
There was a problem hiding this comment.
this java -version check seems weird/wrong since it will ignore the rest of the command instead of aborting
There was a problem hiding this comment.
Yeah, I think that was just added for debugging purposes. @byxorna would be able to tell us for sure though 😄
william-richard
force-pushed
the
will-restrict-package.sh-java-version
branch
from
bc23869
to
22c0f0f
Compare
|
bump @tumblr/collins |
|
LGTM, but i apparently cant give a 👍 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I release collins, I build it with the wrong version of java.
I'm updating the package.sh script to require that you build with 1.7, just so I don't keep making this mistake on releases.
@tumblr/collins