Fix ipmi pool api #554
Merged
Fix ipmi pool api #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I messed this up somehow ever though I checked it a ton of times. Not sure how i missed this but I have since learned pattern matching on scala sets is not that simple. This correctly matches against Sets and non sets. I updated the test to check for the case of two pools being returned since it additionally checks for the case that one pool can be returned. I spend far too much time trying to get different configs to work with the tests I had some luck using FakeApplication and setting some additionalConfig for it. However it turns out that if you have two tests using fake config and they are both different only the first test that runs fake config takes effect and it applies to all the other runs...
Cleanup dead code and also refactor Set check to remove warning about type erasure when matching against a set.
byxorna
approved these changes
Jun 2, 2017
|
pinging @roymarantz @defect to review as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed this up somehow even though I checked it a ton of times. Not sure
how i missed this but I have since learned pattern matching in scala sets
is not that simple. This correctly matches against Sets and non Sets. I
updated the test to check for the case of two pools being returned since it
additionally checks for the case that one pool can be returned.
I spend far too much time trying to get different configs to work with the tests
I had some luck using FakeApplication and setting some additionalConfig for it.
However it turns out that if you have two tests using fake config and they are
both different only the first test that runs fake config takes effect and it applies
to all the other runs...