histogram buckets can be configured through typesafe config #475

Merged
merged 1 commit into from Dec 20, 2016

Projects

None yet

3 participants

@DanSimon
Contributor

This adds a config option for histograms that we missed when moving config to typesafe-config. Histograms by default use 100 buckets on a log scale. This works pretty well for latency when the average is around 100ms or lower. But in many other cases the buckets will not give accurate percentiles, either because something with a non-log distribution is being measured or there are too few buckets to give enough resolution.

So now there are 3 possible ways to configure histogram buckets:

  • manual - you provide list of bucket lower-bounds yourself
  • linearscale - you provide num_buckets and infinity and the range below the infinity value is evenly divided amongst num buckets
  • logscale - same as linear except the natual-log scale is used

the default is set to log-scale with 100 buckets and Int.MaxValue as infinity, which matches the existing defaults.

@DanSimon DanSimon histogram buckets can be configured through typesafe config
f37d29a
@DanSimon DanSimon added this to the 0.8.3 milestone Dec 19, 2016
@codecov-io
codecov-io commented Dec 19, 2016 edited

Current coverage is 83.74% (diff: 72.22%)

Merging #475 into master will decrease coverage by 0.06%

@@             master       #475   diff @@
==========================================
  Files            79         79          
  Lines          3924       3938    +14   
  Methods        3571       3583    +12   
  Messages          0          0          
  Branches        353        355     +2   
==========================================
+ Hits           3289       3298     +9   
- Misses          635        640     +5   
  Partials          0          0          

Powered by Codecov. Last update 909c42b...f37d29a

@benblack86
Member

👍

@DanSimon DanSimon merged commit 73c30f2 into master Dec 20, 2016

2 of 4 checks passed

codecov/patch 72.22% of diff hit (target 83.81%)
Details
codecov/project 83.74% (-0.07%) compared to 909c42b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DanSimon DanSimon deleted the configure-buckets branch Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment