Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: do not redirect if target domain is the same as source #29

Closed
crssi opened this issue Jul 14, 2017 · 10 comments
Closed

Enhancement: do not redirect if target domain is the same as source #29

crssi opened this issue Jul 14, 2017 · 10 comments
Labels

Comments

@crssi
Copy link
Contributor

crssi commented Jul 14, 2017

Don't know how to explain this, but will try.

Can you implement exception checkbox under redirect rule, where redirection would not take place if the redirected domain is the same as source... see debate here sblask-webextensions/webextension-skip-redirect#30 (comment)

@tumpio
Copy link
Owner

tumpio commented Jul 16, 2017

The issue you linked is something over complicated than I was thinking about. I'm not sure what you are after with this.

@tumpio tumpio closed this as completed Jul 16, 2017
@crssi
Copy link
Contributor Author

crssi commented Jul 18, 2017

Sorry, I was AWOL for last days.
I have choose the wrong wordings I believe. The right would be filtering URL.
I would like to skip URL filtering where domain is the same in the URL and in the parameter.

@tumpio
Copy link
Owner

tumpio commented Jul 18, 2017

That may be doable, but not in my top priority. Sorry..

@crssi
Copy link
Contributor Author

crssi commented Jul 18, 2017

I am not trying to make this request top priority. ;)
Thank you

@tumpio
Copy link
Owner

tumpio commented Jul 18, 2017

Well, I leave it open and add help wanted tag for it :)

Also do you have more examples to share?

The issue you linked discusses particularly one single use case for "amazon.com" domain. For this particular case URL redirection filtering should not be applied if both the request URL and the filtered redirection URL are both subdomains of the same main domain "amazon.com".

https://sellercentral.amazon.com/gp/sc-redirect/seller-page.html/ref=v_sp_storefront%5Bblahblah-mysterious-information%5D&servername=www.amazon.com&type=shops

@tumpio
Copy link
Owner

tumpio commented Jul 18, 2017

And how about the multiple top level domains of the same service, like Amazon and Google? Do you require that they are treated as same domain, too?

@crssi
Copy link
Contributor Author

crssi commented Jul 18, 2017

Is that even possible?

@crssi
Copy link
Contributor Author

crssi commented Jul 18, 2017

About examples... I can throw them here when I will stumble on them, but quite a lot of login pages are cowered out of the box with this solution.

@tumpio
Copy link
Owner

tumpio commented Jul 18, 2017

Ok, I leave it open if some one wants to work on it.

tumpio added a commit that referenced this issue Aug 18, 2018
Uses tldjs for domain name parsing.

implements #29
@tumpio
Copy link
Owner

tumpio commented Aug 21, 2018

1.11.0 has support for this.

@tumpio tumpio closed this as completed Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants