Ashish Dixit tundal45

Organizations

@groupon @newhavenrb @UnearthRuby
tundal45 edited the mperham/sidekiq wiki
tundal45 commented on issue emberjs/guides#2
@tundal45

@bsclifton I should have some time this weekend to take a look at this.

@tundal45
tundal45 commented on issue emberjs/guides#2
@tundal45

I can start working on this today.

tundal45 commented on pull request emberjs/guides#53
@tundal45

yayyayyay! <3

tundal45 commented on pull request emberjs/guides#73
@tundal45

This is technically console but javascript felt right.

tundal45 opened pull request emberjs/guides#73
@tundal45
Add fenced code block with language wherever necessary.
1 commit with 110 additions and 92 deletions
tundal45 commented on pull request emberjs/guides#53
@tundal45

@trek Happy to help. I will open the PR that fixes the guides with language-less code blocks shortly.

tundal45 commented on pull request emberjs/guides#53
@tundal45

@trek This addresses all the comments made here as well as those we discussed offline. I have travis running builds on my fork as well so that shou…

@tundal45
@tundal45
@tundal45
tundal45 commented on pull request emberjs/guides#53
@tundal45

@trek I need to squash the intermediary commits but this should have tests that use actual data rather than relying heavily on mocks & stubs. It al…

@tundal45
tundal45 commented on pull request emberjs/guides#53
@tundal45

current_page is not something that we override in the helper and it felt was not in violation of mocking something we don't own. Is the issue that c…

tundal45 commented on pull request emberjs/guides#53
@tundal45

Makes sense. I'll switch back to the old version sans explicit returns.

tundal45 commented on pull request emberjs/guides#53
@tundal45

@trek I had accidentally amended the travis ci commit with the spec changes. Fixed now.

@tundal45
@tundal45
@tundal45
tundal45 commented on pull request emberjs/guides#53
@tundal45

@trek As we discussed, the tests now primarily mock out current_page & data.guides to simulate all the edge cases for various methods in the helper…

@tundal45
tundal45 opened pull request emberjs/guides#53
@tundal45
Handle nil language in highlighter
4 commits with 463 additions and 72 deletions