Skip to content

Conversation

@tunnckoCore
Copy link
Owner

@tunnckoCore tunnckoCore commented Mar 26, 2020

  • options.react -> options.jsx (default: false)
    • allow boolean true, or options object which is passed to the react preset
    • if you want to pass different pragma options.jsx.pragma (which is also passed to the preset-typescript if options.typescript: true
  • options.modules -> options.commonjs (default: false), pass true if you want to transform ESModules to CJS.
  • the defaults of presets/plugins are not touched (so the JSX pragma, for example, is respectively React.createElement as set in preset-react, and React for the typescript preset (its default))

BREAKING CHANGE: rename options, better handling and etc

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
@auto-comment
Copy link

auto-comment bot commented Mar 26, 2020

Thank you for raising your pull request.
Please make sure again that you have followed our contributing guidelines and the code of conduct. We will review it as soon as possible.
Hey @tunnckoCore, check out this one too! ;)

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #130 into master will increase coverage by 0.00%.
The diff coverage is 82.35%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   55.71%   55.72%           
=======================================
  Files          39       39           
  Lines        1251     1258    +7     
  Branches      363      366    +3     
=======================================
+ Hits          697      701    +4     
- Misses        440      443    +3     
  Partials      114      114           
Impacted Files Coverage Δ
@packages/babel-preset-optimise/src/index.js 86.36% <82.35%> (-13.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4bf6f...71a57a5. Read the comment docs.

Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
Signed-off-by: Charlike Mike Reagent <opensource@tunnckocore.com>
@tunnckoCore tunnckoCore changed the title feat(babel-preset-optimise): rename options, better handling & defaults feat(preset-optimise): add & rename options, better defaults Mar 26, 2020
@tunnckoCore tunnckoCore merged commit 3840a62 into master Mar 26, 2020
@tunnckoCore tunnckoCore deleted the babel-preset-update branch March 26, 2020 13:36
@pr-triage pr-triage bot added the PR: merged label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants