This repository has been archived by the owner. It is now read-only.

Turbolinks changes relative anchor links to be absolute #399

Closed
adailey14 opened this Issue Sep 10, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@adailey14

adailey14 commented Sep 10, 2014

Turbolinks changes a link like:

<a href="#article1" data-no-turbolink>Go to article 1</a>

to

<a href="localhost:3000/my/path#article1" data-no-turbolink>Go to article 1</a>

after clicking on it. It appears to do this with or without the data-no-turbolink attribute set.

@reed reed closed this in db992cd Sep 13, 2014

@reed

This comment has been minimized.

Show comment
Hide comment
@reed

reed Sep 13, 2014

Collaborator

Thanks for pointing out the issue. It should be fixed now.

Collaborator

reed commented Sep 13, 2014

Thanks for pointing out the issue. It should be fixed now.

sebastian-julius added a commit to blinkist/turbolinks that referenced this issue Oct 20, 2014

Merge commit 'c5e4ca2e02547e3d0a0ef51bd879d6a41139444f'
* commit 'c5e4ca2e02547e3d0a0ef51bd879d6a41139444f': (52 commits)
  Fix typo
  Avoid double requests on cross origin redirects - Close #260
  v2.4.0
  Don't set request_method cookie for GET requests
  Change Turbolinks.events() array to Turbolinks.EVENTS hash
  Properly ignore empty hash links - Fix #407 again
  Handle HTML parsing bug in Safari 7.1 - Fix #408
  Check if Content-Type header exists before checking its value - Fix #410
  Ignore empty hash links when the current location ends in an empty hash - Fix #407
  expose event list via `Turbolinks.events()`
  Move event names into Turbolinks.EVENTS
  Provide target URL to page:before-change event - Close #357
  Maintain load order of scripts in the body - Fix #389
  Add Prototype compatibility with custom events - Fix #384
  Add page:before-unload event - Close #401
  Move cloning of link element inside the Link class to preserve ability to inspect surrounding elements
  Clarify page:update description in README - Fix #398
  Clone the link so attributes are not altered - Fix #399
  Include check for nil-session
  v2.3.0
  ...

Conflicts:
	lib/turbolinks.rb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.