This repository has been archived by the owner. It is now read-only.

Delay displaying the progress bar for (a default of) 400ms #608

Merged
merged 1 commit into from Sep 13, 2015

Conversation

Projects
None yet
2 participants
@javan
Member

javan commented Sep 13, 2015

progress-bar-timed

  • Default delay: 400ms
  • Default value can be configured: Turbolinks.ProgressBar.setDelay(value)
  • Delay option can be passed to ProgressBar#start: Turbolinks.ProgressBar.start({ delay: value })
@monkbroc

This comment has been minimized.

monkbroc commented Sep 13, 2015

This implementation looks and works great @javan! Thanks for including my suggestion for the start delay option in here. I'lll close #604.

javan added a commit that referenced this pull request Sep 13, 2015

Merge pull request #608 from rails/progress-bar-display-delay
Delay displaying the progress bar for (a default of) 400ms

@javan javan merged commit 6d2ffc0 into master Sep 13, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@javan javan deleted the progress-bar-display-delay branch Sep 13, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.