Allow using of turbolinks gem without Sprockets #18

Merged
merged 1 commit into from Nov 29, 2016

Conversation

Projects
None yet
6 participants
@guilleiguaran
Contributor

guilleiguaran commented Nov 20, 2016

I'm trying to use Turbolinks with Webpack instead of Sprockets, to do this I'm getting turbolinks js from npm package using Yarn but I still want to use this gem to get Turbolinks::Redirection in my controller automatically. This allow to use this gem when Sprockets is not enabled.

Closes #16

@packagethief

This comment has been minimized.

Show comment
Hide comment
Member

packagethief commented Nov 21, 2016

👍

@guilleiguaran guilleiguaran merged commit 20f3bf4 into master Nov 29, 2016

@guilleiguaran guilleiguaran deleted the turbolinks_without_sprockets branch Nov 29, 2016

@aganov

This comment has been minimized.

Show comment
Hide comment
@aganov

aganov Mar 27, 2017

Can we get this released, please?

aganov commented Mar 27, 2017

Can we get this released, please?

@aar0nr

This comment has been minimized.

Show comment
Hide comment
@aar0nr

aar0nr May 4, 2017

With the release of Rails 5.1 and webpacker, I think using turbolinks without the asset pipeline will become a more common scenario. A release with this change would be helpful.

aar0nr commented May 4, 2017

With the release of Rails 5.1 and webpacker, I think using turbolinks without the asset pipeline will become a more common scenario. A release with this change would be helpful.

@aganov

This comment has been minimized.

Show comment
Hide comment
@aganov

aganov Jul 8, 2017

@guilleiguaran @rafaelfranca ping for release please :)

aganov commented Jul 8, 2017

@guilleiguaran @rafaelfranca ping for release please :)

@rebelweb

This comment has been minimized.

Show comment
Hide comment
@rebelweb

rebelweb Dec 12, 2017

I found that referencing this repository's master branch fixed the same issue I was having disabling sprockets. I looked and the most current release on Rubygems is from July of last year, which doesn't include this patch.

I found that referencing this repository's master branch fixed the same issue I was having disabling sprockets. I looked and the most current release on Rubygems is from July of last year, which doesn't include this patch.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Dec 12, 2017

Contributor

Let me check how to release this gem and I'll release it

Contributor

rafaelfranca commented Dec 12, 2017

Let me check how to release this gem and I'll release it

@rebelweb

This comment has been minimized.

Show comment
Hide comment

Thank You @rafaelfranca

@NoelDeMartin NoelDeMartin referenced this pull request in turbolinks/turbolinks Mar 28, 2018

Merged

Update gem installation instructions #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment