Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set newBody property when rendering errors #406

Merged
merged 1 commit into from Jul 27, 2018

Conversation

Projects
None yet
1 participant
@javan
Copy link
Member

javan commented Jul 27, 2018

It's expected by the super class:

renderView: (callback) ->
@delegate.viewWillRender(@newBody)
callback()
@delegate.viewRendered(@newBody)

Fixes that event.data.newBody would be undefined in turbolinks:before-render events for error pages.

Set newBody property when rendering errors
It's expected by the Turbolinks.Renderer super class

@javan javan force-pushed the newbody-for-error-visits branch from 12b93ce to 7a206bc Jul 27, 2018

@javan javan merged commit e7d089f into master Jul 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@javan javan deleted the newbody-for-error-visits branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.