Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Mars.2 not showing workspace label #5279

Open
KarlEilebrecht opened this issue Mar 9, 2016 · 24 comments
Open

Problem with Mars.2 not showing workspace label #5279

KarlEilebrecht opened this issue Mar 9, 2016 · 24 comments
Assignees

Comments

@KarlEilebrecht
Copy link

KarlEilebrecht commented Mar 9, 2016

After using your awesome plugin for a long time with Eclipse Mars.1, I upgraded (Eclipse-internal-update) to Mars.2. Since this time the tiny workspace label does no longer stay(!) on top of the eclipse logo on the Mac OS dock. In other words: after showing up for a moment it vanishes.
I uninstalled the eclipse-launcher and re-installed it - no change.
Is there any workaround?

Confirmed: Same problem for my colleage right after updating to Mars.2.

@turesheim
Copy link
Owner

turesheim commented Mar 11, 2016

How did you install Eclipse? I've seen that Oomph sometimes creates problems with the label.

@turesheim turesheim self-assigned this Mar 11, 2016
@KarlEilebrecht
Copy link
Author

KarlEilebrecht commented Mar 11, 2016

I downloaded Eclipse Mars.1 edition for Java development from eclipse.orghttp://eclipse.org. Later I updated to Mars.2 inside Eclipse. Same for my colleague.

Am 11.03.2016 um 20:32 schrieb Torkild U. Resheim <notifications@github.commailto:notifications@github.com>:

How did you install Eclipse? I've seen that Oomph sometimes creates problems with the label.

Reply to this email directly or view it on GitHubhttps://github.com//issues/5279#issuecomment-195513203.

@turesheim
Copy link
Owner

turesheim commented Mar 11, 2016

Could you please check the log for any exceptions that are suspicious? Also make sure that you're running Eclipse under Java 1.7 or newer.

@KarlEilebrecht
Copy link
Author

KarlEilebrecht commented Mar 12, 2016

eclipse.buildId=4.5.2.M20160212-1500
Java version is 1.8.0_72 (Oracle)

workspace/.metadata/.log does not contain any related error or warning.

@turesheim
Copy link
Owner

turesheim commented Mar 13, 2016

I attempted to reproduce the issue by the following procedure:

  1. Install "Eclipse IDE for Java Developers" Mars.1
  2. Install "OS X Eclipse Launcher Utility"
  3. Set the workspace name to "TEST"
  4. Upgrade to "Eclipse IDE for Java Developers" Mars.2

I was not able to reproduce the problem. Could there be some special characters in the workspace name that causes this? Either in the file path or in the preference. I tried some Unicode for fun but could not break it. If you send me your .log file I might be able to spot the problem.
i-heart-eclipse

For the record what OS X version are you using? It could be related to SWT and OS version. However I cannot see any SWT bugs fixed for 4.5.2 that may be related: https://bugs.eclipse.org/bugs/buglist.cgi?classification=Eclipse&component=SWT&order=Importance&product=Platform&query_format=advanced&target_milestone=4.5.2&target_milestone=4.5.2%2B

@KarlEilebrecht
Copy link
Author

KarlEilebrecht commented Mar 13, 2016

Hi,

Thank you for your quick reply.

Just to be sure not to be on the wrong page, I just took my other mac, already on El Capitain and completely unrelated to my usual work and used "Eclipse -> Help -> Check for Updates", ran the update, restarted and got the exact same behavior: the label above the ecliipse Icon appears at start and vanishes a moment (maybe 1 or 2 seconds) later.

My Mac at work, where I observed the problem first, is Yosemite 10.10.5

At home (same problem): El Capitan 10.11.3

Here is the .log-file from the computer (El Capitan) I just upgraded:
https://www.evernote.com/l/AIz4j2fdZdNMcrjrXoI_2ykyPrFrMDaVotk

@turesheim
Copy link
Owner

turesheim commented Mar 14, 2016

The log file contained nothing interesting. Could you try opening a new fresh workspace and see what happens? What other plug-ins do you have installed?

@turesheim
Copy link
Owner

turesheim commented Mar 14, 2016

I've improved the way the WorkspaceDecorator obtains the handle to the TaskBar and TaskItem. Please try to install from https://resheim.net/p2/eclipse-launcher_test/.

@KarlEilebrecht
Copy link
Author

KarlEilebrecht commented Mar 14, 2016

Unfortunately the new version shows same behavior. After a few seconds the label is gone.
Here I have attached now my full configuration:
https://www.evernote.com/l/AIz4j2fdZdNMcrjrXoI_2ykyPrFrMDaVotk

@FoxyBOA
Copy link

FoxyBOA commented Mar 15, 2016

Have the same problem. Icon (badge) appears sometimes (mainly after -clean option) but most of time it's invisible.

@turesheim
Copy link
Owner

turesheim commented Mar 15, 2016

I'm looking into this. Still trying to reproduce the behavior. Thanks for the configuration Karl. I did not see anything strange in there except that Oomph is installed. I'll have a close look at the Oomph source code as I suspect that it does attempts to set the icon badge when on OS X.

@turesheim
Copy link
Owner

turesheim commented Mar 15, 2016

Yes, so Oomph appears to interfering in it's TaskItemDecorator. However it only uses the workspace name preference setting. So if the name has not been set, the badge will be cleared. Try actively setting the workspace name in General > Workspace > Workspace name.

@bee256
Copy link

bee256 commented Mar 15, 2016

Thanks, Torkild, actively setting the workspace name did the trick. Field was empty…
Bernd

@KarlEilebrecht
Copy link
Author

KarlEilebrecht commented Mar 15, 2016

Fantastic! Made my day! :-)

@richardliechty
Copy link

richardliechty commented Mar 25, 2016

Thanks for the tip. Setting the workspace name is in someways cleaner than long workspace folder names that get trun…ted.

@turesheim
Copy link
Owner

turesheim commented Apr 8, 2016

I think I can close this as resolved although Oomph will interfere.

@F4154LK
Copy link

F4154LK commented Jun 20, 2016

I've just done the upgrade and have the same issue. Manually inserting the names of workspaces is a good work around but not the solution. Will I always have to manually put this in all the time now?

@turesheim
Copy link
Owner

turesheim commented Jun 20, 2016

Yes, until I can convince the Oomph team to not override what this plug-in does or implement the same mechanism for showing the badge. Sorry about that.

@colemarkham
Copy link

colemarkham commented Jun 20, 2016

Do you have a bug on Oomph? I'd be happy to comment/vote there.

@turesheim turesheim reopened this Jun 21, 2016
@turesheim
Copy link
Owner

turesheim commented Jun 21, 2016

@jfrantzius
Copy link

jfrantzius commented Jan 23, 2017

It seems that the workaround doesn't work around anymore with Neon.2, at least for me. Does it still work for somebody else in Neon.2?

@turesheim
Copy link
Owner

turesheim commented Jan 23, 2017

Yes, it's broken. Probably for other reasons. See bug #5281.

@takacsot
Copy link

takacsot commented Feb 6, 2018

My temporary workaround:
setting: General > Startup and Shutdown
And there I have unchecked Oomph related pugins (not to activate on startup.

@edfink
Copy link

edfink commented Jun 6, 2018

FYI, the badge wasn't showing for me on Oxygen.3a. Disabling Oomph as @takacsot mentioned above "fixed" it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants